Closed
Bug 1323186
Opened 8 years ago
Closed 8 years ago
[Static Analysis][Result is Not Floating Point] In function ConstructBorderRenderer
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1396320)
Attachments
(1 file)
The Static Analysis tool Coverity detected that the result of the following operations is not floating point:
>> Float borderWidths[4] = { Float(border.top / twipsPerPixel),
>> Float(border.right / twipsPerPixel),
>> Float(border.bottom / twipsPerPixel),
>> Float(border.left / twipsPerPixel) };
The correct approach is:
>> Float borderWidths[4] = { Float(border.top) / twipsPerPixel,
>> Float(border.right) / twipsPerPixel,
>> Float(border.bottom) / twipsPerPixel,
>> Float(border.left) / twipsPerPixel };
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8818245 -
Flags: review?(matt.woodrow)
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8818245 [details]
Bug 1323186 - ensure the result of the operation is floating point.
https://reviewboard.mozilla.org/r/98396/#review98686
Attachment #8818245 -
Flags: review?(matt.woodrow) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a1b2bb85201
ensure the result of the operation is floating point. r=mattwoodrow
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•